scsi: qedf: Replace deprecated strncpy() with strscpy()
authorJustin Stitt <justinstitt@google.com>
Tue, 5 Mar 2024 23:34:38 +0000 (23:34 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sun, 10 Mar 2024 22:37:43 +0000 (18:37 -0400)
commit2303149d584feade8074295b717451b36ac63307
tree0f3fd40e9b409d815571e52a0cdbd152a5c19036
parentb7e9712a02e869d2c15a3a2284b078771fd484d7
scsi: qedf: Replace deprecated strncpy() with strscpy()

We expect slowpath_params.name to be NUL-terminated based on its future
usage with other string APIs:

| static int qed_slowpath_start(struct qed_dev *cdev,
|       struct qed_slowpath_params *params)
...
| strscpy(drv_version.name, params->name,
| MCP_DRV_VER_STR_SIZE - 4);

Moreover, NUL-padding is not necessary as the only use for this slowpath
name parameter is to copy into the drv_version.name field.

Also, let's prefer using strscpy(src, dest, sizeof(src)) in two instances
(one of which is outside of the scsi system but it is trivial and related
to this patch).

We can see the drv_version.name size here:
| struct qed_mcp_drv_version {
| u32 version;
| u8 name[MCP_DRV_VER_STR_SIZE - 4];
| };

Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Link: https://lore.kernel.org/r/20240305-strncpy-drivers-scsi-mpi3mr-mpi3mr_fw-c-v3-3-5b78a13ff984@google.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/net/ethernet/qlogic/qed/qed_main.c
drivers/scsi/qedf/qedf_main.c