usbnet: ipheth: fix risk of NULL pointer deallocation
authorGeorgi Valkov <gvalkov@gmail.com>
Wed, 7 Jun 2023 13:56:59 +0000 (15:56 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Jun 2023 09:26:57 +0000 (10:26 +0100)
commit2203718c2f59ffdd6c78d54e5add594aebb4461e
tree8e909ff2119179b861f0ad8d6132d2f099b7ad8a
parentfd5f4d7da29218485153fd8b4c08da7fc130c79f
usbnet: ipheth: fix risk of NULL pointer deallocation

The cleanup precedure in ipheth_probe will attempt to free a
NULL pointer in dev->ctrl_buf if the memory allocation for
this buffer is not successful. While kfree ignores NULL pointers,
and the existing code is safe, it is a better design to rearrange
the goto labels and avoid this.

Signed-off-by: Georgi Valkov <gvalkov@gmail.com>
Signed-off-by: Foster Snowhill <forst@pen.gy>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/ipheth.c