platform/x86: thinkpad_acpi: remove redundant assignment to variable i
authorColin Ian King <colin.i.king@gmail.com>
Sat, 6 Jan 2024 15:47:40 +0000 (15:47 +0000)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Wed, 24 Jan 2024 10:33:17 +0000 (12:33 +0200)
commit214509e5d61d294193b220f397418e76879f74c0
treeb0677198e62636202a8ae8114b99fc7ffa838991
parent6613476e225e090cc9aad49be7fa504e290dd33d
platform/x86: thinkpad_acpi: remove redundant assignment to variable i

The variable i is being initialized with the value 0 that is never
read, it is being re-assigned 0 again in a for-loop statement later
on. The initialization is redundant and can be removed.

The initialization of variable n can also be deferred after the
sanity check on pointer n and the declaration of all the int variables
can be combined as a final code clear-up.

Cleans up clang scan build warning:
warning: Value stored to 'i' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20240106154740.55202-1-colin.i.king@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/thinkpad_acpi.c