drm/mediatek: Fix device/node reference count leaks in mtk_drm_get_all_drm_priv
authorMa Ke <make24@iscas.ac.cn>
Tue, 12 Aug 2025 07:19:32 +0000 (15:19 +0800)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Fri, 15 Aug 2025 23:35:35 +0000 (23:35 +0000)
commit1f403699c40f0806a707a9a6eed3b8904224021a
treed36841e43fe901f94b9d50d78dbf7d9e09c13a40
parentf5b1819193667bf62c3c99d3921b9429997a14b2
drm/mediatek: Fix device/node reference count leaks in mtk_drm_get_all_drm_priv

Using device_find_child() and of_find_device_by_node() to locate
devices could cause an imbalance in the device's reference count.
device_find_child() and of_find_device_by_node() both call
get_device() to increment the reference count of the found device
before returning the pointer. In mtk_drm_get_all_drm_priv(), these
references are never released through put_device(), resulting in
permanent reference count increments. Additionally, the
for_each_child_of_node() iterator fails to release node references in
all code paths. This leaks device node references when loop
termination occurs before reaching MAX_CRTC. These reference count
leaks may prevent device/node resources from being properly released
during driver unbind operations.

As comment of device_find_child() says, 'NOTE: you will need to drop
the reference with put_device() after use'.

Cc: stable@vger.kernel.org
Fixes: 1ef7ed48356c ("drm/mediatek: Modify mediatek-drm for mt8195 multi mmsys support")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20250812071932.471730-1-make24@iscas.ac.cn/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_drm_drv.c