rfs: annotate lockless accesses to sk->sk_rxhash
authorEric Dumazet <edumazet@google.com>
Tue, 6 Jun 2023 07:41:14 +0000 (07:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Jun 2023 09:08:45 +0000 (10:08 +0100)
commit1e5c647c3f6d4f8497dedcd226204e1880e0ffb3
treeaca249e3fd5b97c6834ecd59203cb1f2f1e588af
parentab39b113e74751958aac1b125a14ee42bd7d3efd
rfs: annotate lockless accesses to sk->sk_rxhash

Add READ_ONCE()/WRITE_ONCE() on accesses to sk->sk_rxhash.

This also prevents a (smart ?) compiler to remove the condition in:

if (sk->sk_rxhash != newval)
sk->sk_rxhash = newval;

We need the condition to avoid dirtying a shared cache line.

Fixes: fec5e652e58f ("rfs: Receive Flow Steering")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/sock.h