ksmbd: Fix dangling pointer in krb_authenticate
authorSean Heelan <seanheelan@gmail.com>
Mon, 7 Apr 2025 11:26:50 +0000 (11:26 +0000)
committerSteve French <stfrench@microsoft.com>
Tue, 15 Apr 2025 03:21:26 +0000 (22:21 -0500)
commit1e440d5b25b7efccb3defe542a73c51005799a5f
tree63f22353c1fd445c53cce348d59ada2b5133eed2
parent8ffd015db85fea3e15a77027fda6c02ced4d2444
ksmbd: Fix dangling pointer in krb_authenticate

krb_authenticate frees sess->user and does not set the pointer
to NULL. It calls ksmbd_krb5_authenticate to reinitialise
sess->user but that function may return without doing so. If
that happens then smb2_sess_setup, which calls krb_authenticate,
will be accessing free'd memory when it later uses sess->user.

Cc: stable@vger.kernel.org
Signed-off-by: Sean Heelan <seanheelan@gmail.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb2pdu.c