x86/syscall: Don't force use of indirect calls for system calls
authorLinus Torvalds <torvalds@linux-foundation.org>
Wed, 3 Apr 2024 23:36:44 +0000 (16:36 -0700)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 8 Apr 2024 17:27:05 +0000 (19:27 +0200)
commit1e3ad78334a69b36e107232e337f9d693dcc9df2
tree11162955093106a59ca3825365580797e0aff750
parent0cd01ac5dcb1e18eb18df0f0d05b5de76522a437
x86/syscall: Don't force use of indirect calls for system calls

Make <asm/syscall.h> build a switch statement instead, and the compiler can
either decide to generate an indirect jump, or - more likely these days due
to mitigations - just a series of conditional branches.

Yes, the conditional branches also have branch prediction, but the branch
prediction is much more controlled, in that it just causes speculatively
running the wrong system call (harmless), rather than speculatively running
possibly wrong random less controlled code gadgets.

This doesn't mitigate other indirect calls, but the system call indirection
is the first and most easily triggered case.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Daniel Sneddon <daniel.sneddon@linux.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Josh Poimboeuf <jpoimboe@kernel.org>
arch/x86/entry/common.c
arch/x86/entry/syscall_32.c
arch/x86/entry/syscall_64.c
arch/x86/entry/syscall_x32.c
arch/x86/include/asm/syscall.h