genetlink: fix genl_bind() invoking bind() after -EPERM
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Fri, 5 Sep 2025 13:57:27 +0000 (06:57 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 9 Sep 2025 00:50:36 +0000 (17:50 -0700)
commit1dbfb0363224f6da56f6655d596dc5097308d6f5
treef454799d23cdc482f42d6622e967b9f1a2996864
parente2a10daba84968f6b5777d150985fd7d6abc9c84
genetlink: fix genl_bind() invoking bind() after -EPERM

Per family bind/unbind callbacks were introduced to allow families
to track multicast group consumer presence, e.g. to start or stop
producing events depending on listeners.

However, in genl_bind() the bind() callback was invoked even if
capability checks failed and ret was set to -EPERM. This means that
callbacks could run on behalf of unauthorized callers while the
syscall still returned failure to user space.

Fix this by only invoking bind() after "if (ret) break;" check
i.e. after permission checks have succeeded.

Fixes: 3de21a8990d3 ("genetlink: Add per family bind/unbind callbacks")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20250905135731.3026965-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/netlink/genetlink.c