pinctrl: aspeed: Use the right pinconf mask
authorAndrew Jeffery <andrew@aj.id.au>
Thu, 10 Sep 2020 02:56:30 +0000 (12:26 +0930)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 29 Sep 2020 12:38:44 +0000 (14:38 +0200)
commit1d6db5ae6b090d1a8edfcb36b9bf47c5f4fe27f6
tree651c32d9411bb99e828797647fba6736a7fcc1cb
parent7e8d8ac78f35b2fc8cb1548f4ea5f5d9eaf3b3f8
pinctrl: aspeed: Use the right pinconf mask

The Aspeed pinconf data structures are split into 'conf' and 'map'
types, where the 'conf' struct defines which register and bitfield to
manipulate, while the 'map' struct defines what value to write to
the register and bitfield.

Both structs have a mask member, and the wrong mask was being used to
tell the regmap which bits to update.

A todo is to look at whether we can remove the mask from the 'map'
struct.

Fixes: 5f52c853847f ("pinctrl: aspeed: Use masks to describe pinconf bitfields")
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Cc: Johnny Huang <johnny_huang@aspeedtech.com>
Link: https://lore.kernel.org/r/20200910025631.2996342-3-andrew@aj.id.au
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/aspeed/pinctrl-aspeed.c