mm: kfence: fix using kfence_metadata without initialization in show_object()
authorMuchun Song <songmuchun@bytedance.com>
Wed, 15 Mar 2023 03:44:41 +0000 (11:44 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 24 Mar 2023 00:18:35 +0000 (17:18 -0700)
commit1c86a188e03156223a34d09ce290b49bd4dd0403
treea5d6a977efb9fdb8aac4bf556d6acd93f0d2401f
parent13684e966d46283e0e89b6a4941596dc52b18bf3
mm: kfence: fix using kfence_metadata without initialization in show_object()

The variable kfence_metadata is initialized in kfence_init_pool(), then,
it is not initialized if kfence is disabled after booting.  In this case,
kfence_metadata will be used (e.g.  ->lock and ->state fields) without
initialization when reading /sys/kernel/debug/kfence/objects.  There will
be a warning if you enable CONFIG_DEBUG_SPINLOCK.  Fix it by creating
debugfs files when necessary.

Link: https://lkml.kernel.org/r/20230315034441.44321-1-songmuchun@bytedance.com
Fixes: 0ce20dd84089 ("mm: add Kernel Electric-Fence infrastructure")
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Tested-by: Marco Elver <elver@google.com>
Reviewed-by: Marco Elver <elver@google.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Jann Horn <jannh@google.com>
Cc: SeongJae Park <sjpark@amazon.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/kfence/core.c