usb: gadget: u_serial: Avoid double unlock of serial_port_lock
authorPrashanth K <prashanth.k@oss.qualcomm.com>
Tue, 6 May 2025 10:49:12 +0000 (16:19 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 May 2025 11:10:07 +0000 (13:10 +0200)
commit1c06aff9b82fc3795a80feeb23935b9a44b07e71
tree78d336bf9bd5d788ecfe695fd6ecd1ac1cfef680
parenta541acceedf4f639f928f41fbb676b75946dc295
usb: gadget: u_serial: Avoid double unlock of serial_port_lock

Avoid unlocking serial_port_lock twice in gserial_suspend(), this can
occur if gserial_wakeup_host() fails. And since wakeup is performed
outside spinlock, check if the port is valid before proceeding again.

Fixes: 3baea29dc0a7 ("usb: gadget: u_serial: Implement remote wakeup capability")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aBHatifO5bjR1yPt@stanley.mountain/
Signed-off-by: Prashanth K <prashanth.k@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250506104912.3750934-1-prashanth.k@oss.qualcomm.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/u_serial.c