firewire: net: fix unicast reception RCODE in failure paths
authorStefan Richter <stefanr@s5r6.in-berlin.de>
Mon, 16 Aug 2010 21:45:54 +0000 (23:45 +0200)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Thu, 19 Aug 2010 18:28:25 +0000 (20:28 +0200)
commit1bf145fed572583d4cb7c1784689a0b42c997ba6
tree3ef524b2af2ea77f2ea99478b8a4058a8cf07d13
parenta481e97d3cdc40b9d58271675bd4f0abb79d4872
firewire: net: fix unicast reception RCODE in failure paths

The incoming request hander fwnet_receive_packet() expects subsequent
datagram handling code to return non-zero on errors.  However, almost
none of the failure paths did so.  Fix them all.

(This error reporting is used to send and RCODE_CONFLICT_ERROR to the
sender node in such failure cases.  Two modes of failure exist:  Out of
memory, or firewire-net is unaware of any peer node to which a fragment
or an ARP packet belongs.  However, it is unclear whether a sender can
actually make use of such information.  A Linux peer apparently can't.
Maybe it should all be simplified to void functions.)

Reported-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/firewire/net.c