x86/apic: Handle zero vector gracefully in clear_vector_irq()
authorKeith Busch <keith.busch@intel.com>
Wed, 27 Apr 2016 20:22:32 +0000 (14:22 -0600)
committerThomas Gleixner <tglx@linutronix.de>
Thu, 28 Apr 2016 07:53:06 +0000 (09:53 +0200)
commit1bdb8970392a68489b469c3a330a1adb5ef61beb
tree11025813d263bc88cbafe5e0d892e2dac11bddbf
parente16d8a6cbb499c5c8bfe9330d3351b649bded4af
x86/apic: Handle zero vector gracefully in clear_vector_irq()

If x86_vector_alloc_irq() fails x86_vector_free_irqs() is invoked to cleanup
the already allocated vectors. This subsequently calls clear_vector_irq().

The failed irq has no vector assigned, which triggers the BUG_ON(!vector) in
clear_vector_irq().

We cannot suppress the call to x86_vector_free_irqs() for the failed
interrupt, because the other data related to this irq must be cleaned up as
well. So calling clear_vector_irq() with vector == 0 is legitimate.

Remove the BUG_ON and return if vector is zero,

[ tglx: Massaged changelog ]

Fixes: b5dc8e6c21e7 "x86/irq: Use hierarchical irqdomain to manage CPU interrupt vectors"
Signed-off-by: Keith Busch <keith.busch@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
arch/x86/kernel/apic/vector.c