rcu/nocb: Fix possible invalid rdp's->nocb_cb_kthread pointer access
authorZqiang <qiang.zhang1211@gmail.com>
Wed, 7 May 2025 11:26:05 +0000 (19:26 +0800)
committerNeeraj Upadhyay (AMD) <neeraj.upadhyay@kernel.org>
Tue, 8 Jul 2025 18:12:51 +0000 (23:42 +0530)
commit1bba3900ca18bdae28d1b9fa10f16a8f8cb2ada1
treecf460664117260f913053dd1461b33908dc75fc0
parenta33ad03aaed2c39d29a27a64ee55ff919810de59
rcu/nocb: Fix possible invalid rdp's->nocb_cb_kthread pointer access

In the preparation stage of CPU online, if the corresponding
the rdp's->nocb_cb_kthread does not exist, will be created,
there is a situation where the rdp's rcuop kthreads creation fails,
and then de-offload this CPU's rdp, does not assign this CPU's
rdp->nocb_cb_kthread pointer, but this rdp's->nocb_gp_rdp and
rdp's->rdp_gp->nocb_gp_kthread is still valid.

This will cause the subsequent re-offload operation of this offline
CPU, which will pass the conditional check and the kthread_unpark()
will access invalid rdp's->nocb_cb_kthread pointer.

This commit therefore use rdp's->nocb_gp_kthread instead of
rdp_gp's->nocb_gp_kthread for safety check.

Signed-off-by: Zqiang <qiang.zhang1211@gmail.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Neeraj Upadhyay (AMD) <neeraj.upadhyay@kernel.org>
kernel/rcu/tree_nocb.h