lib: test_scanf: Remove pointless use of type_min() with unsigned types
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Tue, 25 May 2021 12:20:11 +0000 (13:20 +0100)
committerPetr Mladek <pmladek@suse.com>
Thu, 27 May 2021 13:38:03 +0000 (15:38 +0200)
commit1b932689c77766b68e2ead51ca0fb84ec5bb8965
tree21122208e0a00f3c39c351bbf8d6b0df2fe6b853
parentef04d4ff4b19628c78abddc768acce097d35d086
lib: test_scanf: Remove pointless use of type_min() with unsigned types

sparse was producing warnings of the form:

 sparse: cast truncates bits from constant value (ffff0001 becomes 1)

There is no actual problem here. Using type_min() on an unsigned type
results in an (expected) truncation.

However, there is no need to test an unsigned value against type_min().
The minimum value of an unsigned is obviously 0, and any value cast to
an unsigned type is >= 0, so for unsigneds only type_max() need be tested.

This patch also takes the opportunity to clean up the implementation of
simple_numbers_loop() to use a common pattern for the positive and
negative test.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20210525122012.6336-2-rf@opensource.cirrus.com
lib/test_scanf.c