platform/x86: dell-uart-backlight: fix serdev race
authorChenyuan Yang <chenyuan0y@gmail.com>
Sat, 11 Jan 2025 18:01:18 +0000 (12:01 -0600)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 14 Jan 2025 16:29:59 +0000 (18:29 +0200)
commit1b2128aa2d45ab20b22548dcf4b48906298ca7fd
tree4d10cd48a5278ce57a1dbec57a56dbb3dd5514a5
parent1d7461d0c8330689117286169106af6531a747ed
platform/x86: dell-uart-backlight: fix serdev race

The dell_uart_bl_serdev_probe() function calls devm_serdev_device_open()
before setting the client ops via serdev_device_set_client_ops(). This
ordering can trigger a NULL pointer dereference in the serdev controller's
receive_buf handler, as it assumes serdev->ops is valid when
SERPORT_ACTIVE is set.

This is similar to the issue fixed in commit 5e700b384ec1
("platform/chrome: cros_ec_uart: properly fix race condition") where
devm_serdev_device_open() was called before fully initializing the
device.

Fix the race by ensuring client ops are set before enabling the port via
devm_serdev_device_open().

Note, serdev_device_set_baudrate() and serdev_device_set_flow_control()
calls should be after the devm_serdev_device_open() call.

Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver")
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20250111180118.2274516-1-chenyuan0y@gmail.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/dell/dell-uart-backlight.c