bpf: task_group_seq_get_next: cleanup the usage of next_thread()
authorOleg Nesterov <oleg@redhat.com>
Tue, 5 Sep 2023 15:46:46 +0000 (17:46 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 8 Sep 2023 15:42:19 +0000 (08:42 -0700)
commit1a00ef57d9f120b711b6b1193d12ba3789d47ec2
treec36fa91e3f80139c3e82cfd267f6f3ee36940149
parent35897c3c5264469cbd45e44d23c165a08cfb6b3c
bpf: task_group_seq_get_next: cleanup the usage of next_thread()

1. find_pid_ns() + get_pid_task() under rcu_read_lock() guarantees that we
   can safely iterate the task->thread_group list. Even if this task exits
   right after get_pid_task() (or goto retry) and pid_alive() returns 0.

   Kill the unnecessary pid_alive() check.

2. next_thread() simply can't return NULL, kill the bogus "if (!next_task)"
   check.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
Link: https://lore.kernel.org/r/20230905154646.GA24928@redhat.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
kernel/bpf/task_iter.c