net: davicom: fix UAF in dm9000_drv_remove
authorChenyuan Yang <chenyuan0y@gmail.com>
Thu, 23 Jan 2025 21:42:13 +0000 (15:42 -0600)
committerJakub Kicinski <kuba@kernel.org>
Mon, 27 Jan 2025 23:05:37 +0000 (15:05 -0800)
commit19e65c45a1507a1a2926649d2db3583ed9d55fd9
tree30bd42364bcb5c802c44fa2c0951079699494b90
parentbd1bbab717608757cccbbe08b0d46e6c3ed0ced5
net: davicom: fix UAF in dm9000_drv_remove

dm is netdev private data and it cannot be
used after free_netdev() call. Using dm after free_netdev()
can cause UAF bug. Fix it by moving free_netdev() at the end of the
function.

This is similar to the issue fixed in commit
ad297cd2db89 ("net: qcom/emac: fix UAF in emac_remove").

This bug is detected by our static analysis tool.

Fixes: cf9e60aa69ae ("net: davicom: Fix regulator not turned off on driver removal")
Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com>
CC: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20250123214213.623518-1-chenyuan0y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/davicom/dm9000.c