block: Optimize disk zone resource cleanup
authorDamien Le Moal <dlemoal@kernel.org>
Fri, 7 Jun 2024 00:21:26 +0000 (09:21 +0900)
committerJens Axboe <axboe@kernel.dk>
Wed, 12 Jun 2024 16:56:45 +0000 (10:56 -0600)
commit1933192a91be0a570663a3c6310c46e4ce3b2baa
treeaca23fcba9e3b3c47f4483d671373da1bdafcf36
parent9b1ebce6a1fded90d4a1c6c57dc6262dac4c4c14
block: Optimize disk zone resource cleanup

For zoned block devices using zone write plugging, an rcu_barrier() call
is needed in disk_free_zone_resources() to synchronize freeing of zone
write plugs and the destrution of the mempool used to allocate the
plugs. The barrier call does slow down a little teardown of zoned block
devices but should not affect teardown of regular block devices or zoned
block devices that do not use zone write plugging (e.g. zoned DM devices
that do not require zone append emulation).

Modify disk_free_zone_resources() to return early if we do not have a
mempool to start with, that is, if the device does not use zone write
plugging. This avoids the costly rcu_barrier() and speeds up disk
teardown.

Reported-by: Mikulas Patocka <mpatocka@redhat.com>
Fixes: dd291d77cc90 ("block: Introduce zone write plugging")
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Tested-by: Mikulas Patocka <mpatocka@redhat.com>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
Link: https://lore.kernel.org/r/20240607002126.104227-1-dlemoal@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-zoned.c