net: caif: fix memory leak in ldisc_open
authorPavel Skripkin <paskripkin@gmail.com>
Sat, 12 Jun 2021 14:51:22 +0000 (17:51 +0300)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:47:21 +0000 (08:47 -0400)
commit18ed1789bbce54f34367877344e35d9bb877f8f4
tree2e4c87315f1ce3114b21d0ec5481711a607cb08b
parentedcd7594ada9204744f7208176c690ba36d13b07
net: caif: fix memory leak in ldisc_open

[ Upstream commit 58af3d3d54e87bfc1f936e16c04ade3369d34011 ]

Syzbot reported memory leak in tty_init_dev().
The problem was in unputted tty in ldisc_open()

static int ldisc_open(struct tty_struct *tty)
{
...
ser->tty = tty_kref_get(tty);
...
result = register_netdevice(dev);
if (result) {
rtnl_unlock();
free_netdev(dev);
return -ENODEV;
}
...
}

Ser pointer is netdev private_data, so after free_netdev()
this pointer goes away with unputted tty reference. So, fix
it by adding tty_kref_put() before freeing netdev.

Reported-and-tested-by: syzbot+f303e045423e617d2cad@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/caif/caif_serial.c