crypto: lib/sha256 - Use memzero_explicit() for clearing state
authorArvind Sankar <nivedita@alum.mit.edu>
Sun, 25 Oct 2020 14:31:14 +0000 (10:31 -0400)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 30 Oct 2020 06:35:03 +0000 (17:35 +1100)
commit1762818f25f3f99c5083caa13d69e5e5aa2e4b6f
tree09fd538f8085ed4d5f944eaa50eaabb6177fa9e9
parent383e8a823014532ffd81c787ef9009f1c2bd3b79
crypto: lib/sha256 - Use memzero_explicit() for clearing state

Without the barrier_data() inside memzero_explicit(), the compiler may
optimize away the state-clearing if it can tell that the state is not
used afterwards. At least in lib/crypto/sha256.c:__sha256_final(), the
function can get inlined into sha256(), in which case the memset is
optimized away.

Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
lib/crypto/sha256.c