tls: fix use-after-free on failed backlog decryption
authorSabrina Dubroca <sd@queasysnail.net>
Wed, 28 Feb 2024 22:44:00 +0000 (23:44 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Feb 2024 17:07:16 +0000 (09:07 -0800)
commit13114dc5543069f7b97991e3b79937b6da05f5b0
treeedca5dcec127fc1268a474167cafa13303931f9e
parent41532b785e9d79636b3815a64ddf6a096647d011
tls: fix use-after-free on failed backlog decryption

When the decrypt request goes to the backlog and crypto_aead_decrypt
returns -EBUSY, tls_do_decryption will wait until all async
decryptions have completed. If one of them fails, tls_do_decryption
will return -EBADMSG and tls_decrypt_sg jumps to the error path,
releasing all the pages. But the pages have been passed to the async
callback, and have already been released by tls_decrypt_done.

The only true async case is when crypto_aead_decrypt returns
 -EINPROGRESS. With -EBUSY, we already waited so we can tell
tls_sw_recvmsg that the data is available for immediate copy, but we
need to notify tls_decrypt_sg (via the new ->async_done flag) that the
memory has already been released.

Fixes: 859054147318 ("net: tls: handle backlogging of crypto requests")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://lore.kernel.org/r/4755dd8d9bebdefaa19ce1439b833d6199d4364c.1709132643.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/tls/tls_sw.c