ext4: do not allow external inodes for inline data
authorTheodore Ts'o <tytso@mit.edu>
Tue, 22 May 2018 20:15:24 +0000 (16:15 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 22 May 2018 20:15:24 +0000 (16:15 -0400)
commit117166efb1ee8f13c38f9e96b258f16d4923f888
treea0b934b5cbeb7d1b42982796a19cf93e28f05fa5
parentf06925c7394236d769c788940c9a7b85dbe4c40c
ext4: do not allow external inodes for inline data

The inline data feature was implemented before we added support for
external inodes for xattrs.  It makes no sense to support that
combination, but the problem is that there are a number of extended
attribute checks that are skipped if e_value_inum is non-zero.

Unfortunately, the inline data code is completely e_value_inum
unaware, and attempts to interpret the xattr fields as if it were an
inline xattr --- at which point, Hilarty Ensues.

This addresses CVE-2018-11412.

https://bugzilla.kernel.org/show_bug.cgi?id=199803

Reported-by: Jann Horn <jannh@google.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Fixes: e50e5129f384 ("ext4: xattr-in-inode support")
Cc: stable@kernel.org
fs/ext4/inline.c