idpf: fix potential use-after-free in idpf_tso()
authorEric Dumazet <edumazet@google.com>
Fri, 3 Nov 2023 20:04:51 +0000 (20:04 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 7 Nov 2023 01:24:37 +0000 (17:24 -0800)
commit115c0f4d58574524ed7fbbcce1b0a86aa5249db1
treebed19fcf7954e8fef8565283e3a6632952fd31e8
parent9fc3bc7643341dc5be7d269f3d3dbe441d8d7ac3
idpf: fix potential use-after-free in idpf_tso()

skb_cow_head() can change skb->head (and thus skb_shinfo(skb))

We must not cache skb_shinfo(skb) before skb_cow_head().

Fixes: 6818c4d5b3c2 ("idpf: add splitq start_xmit")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Joshua Hay <joshua.a.hay@intel.com>
Cc: Alan Brady <alan.brady@intel.com>
Cc: Madhu Chittim <madhu.chittim@intel.com>
Cc: Phani Burra <phani.r.burra@intel.com>
Cc: Sridhar Samudrala <sridhar.samudrala@intel.com>
Cc: Willem de Bruijn <willemb@google.com>
Cc: Pavan Kumar Linga <pavan.kumar.linga@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Bailey Forrest <bcf@google.com>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20231103200451.514047-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/idpf/idpf_txrx.c