udp: also consider secpath when evaluating ipsec use for checksumming
authorSabrina Dubroca <sd@queasysnail.net>
Mon, 4 Aug 2025 09:26:27 +0000 (11:26 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Thu, 7 Aug 2025 06:07:15 +0000 (08:07 +0200)
commit1118aaa3b35157777890fffab91d8c1da841b20b
tree301341654e336b786df9ac2747b4f313bd0fe421
parent65f079a6c446a939eefe71e6d5957d5d6365fcf9
udp: also consider secpath when evaluating ipsec use for checksumming

Commit b40c5f4fde22 ("udp: disable inner UDP checksum offloads in
IPsec case") tried to fix checksumming in UFO when the packets are
going through IPsec, so that we can't rely on offloads because the UDP
header and payload will be encrypted.

But when doing a TCP test over VXLAN going through IPsec transport
mode with GSO enabled (esp4_offload module loaded), I'm seeing broken
UDP checksums on the encap after successful decryption.

The skbs get to udp4_ufo_fragment/__skb_udp_tunnel_segment via
__dev_queue_xmit -> validate_xmit_skb -> skb_gso_segment and at this
point we've already dropped the dst (unless the device sets
IFF_XMIT_DST_RELEASE, which is not common), so need_ipsec is false and
we proceed with checksum offload.

Make need_ipsec also check the secpath, which is not dropped on this
callpath.

Fixes: b40c5f4fde22 ("udp: disable inner UDP checksum offloads in IPsec case")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/ipv4/udp_offload.c