scsi: core: Add a precondition check in scsi_eh_scmd_add()
authorBart Van Assche <bvanassche@acm.org>
Wed, 15 Nov 2023 19:33:43 +0000 (11:33 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 25 Nov 2023 00:23:44 +0000 (19:23 -0500)
commit10b53db2db8dfda84b25833043f2b63123572af6
treefa620f73a3687e516fe57536d5195619100b3f17
parent0349be31e4ffc79723e46e2e373569567b06347b
scsi: core: Add a precondition check in scsi_eh_scmd_add()

Calling scsi_eh_scmd_add() may cause the error handler never to be woken up
because this may result in shost->host_failed to become larger than
scsi_host_busy(shost). Hence complain if scsi_eh_scmd_add() is called after
SCMD_STATE_INFLIGHT has been cleared.

Cc: Hannes Reinecke <hare@suse.de>
Cc: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Mike Christie <michael.christie@oracle.com>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20231115193343.2262013-1-bvanassche@acm.org
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_error.c