media: pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error...
authorYizhuo <yzhai003@ucr.edu>
Mon, 26 Aug 2019 23:55:28 +0000 (20:55 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 29 Aug 2019 13:22:39 +0000 (10:22 -0300)
commit0fb68ce02ae73626a61b8d03eab1625021057af5
treefe6e473c763090df774b9b4437fcb18e809a42bb
parentecbce48f1ff2442371ebcd12ec0ecddb431fbd72
media: pvrusb2: qctrl.flag will be uninitlaized if cx2341x_ctrl_query() returns error code

Inside function ctrl_cx2341x_getv4lflags(), qctrl.flag
will be uninitlaized if cx2341x_ctrl_query() returns -EINVAL.
However, it will be used in the later if statement, which is
potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
Acked-by: Mike Isely <isely@pobox.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/pvrusb2/pvrusb2-hdw.c