drm/i915/ringbuffer: Flush writes before RING_TAIL update
authorChris Wilson <chris@chris-wilson.co.uk>
Mon, 9 Sep 2019 11:30:18 +0000 (12:30 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Tue, 10 Sep 2019 10:48:13 +0000 (11:48 +0100)
commit0efa99dd58754d23e884b9ba41cd601f01b58c3d
treea8b939d68da958d6b3d3688f04390b17cf20a4fb
parent198d2533669bbe162e52eee2c35ddd8594967556
drm/i915/ringbuffer: Flush writes before RING_TAIL update

Be paranoid and make sure we flush any and all writes out of the WCB
before performing the UC mmio to update the RING_TAIL. (An UC write
should itself be enough to do the flush, hence the paranoia here.) Quite
infrequently, we see problems where the GPU seems to overshoot the
RING_TAIL and so executes garbage, hence the speculation.

References: https://bugs.freedesktop.org/show_bug.cgi?id=111598
References: https://bugs.freedesktop.org/show_bug.cgi?id=111417
References: https://bugs.freedesktop.org/show_bug.cgi?id=111034
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190909113018.13300-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_ringbuffer.c