ASoC: stm: stm32_i2s: Fix calc_clk_div() error handling in determine_rate()
authorSergio Perez Gonzalez <sperezglz@gmail.com>
Tue, 29 Jul 2025 02:00:49 +0000 (20:00 -0600)
committerMark Brown <broonie@kernel.org>
Tue, 12 Aug 2025 20:15:29 +0000 (21:15 +0100)
commit0ebbab41fba1bae6ccd96c0eec17026700ac6534
tree23b588d8878a37c89c84585067807d37eb1c2928
parentdcb82900b12f5809e66835918d4043284ce1d39c
ASoC: stm: stm32_i2s: Fix calc_clk_div() error handling in determine_rate()

calc_clk_div() will only return a non-zero value (-EINVAL)
in case of error. On the other hand, req->rate is an unsigned long.
It seems quite odd that req->rate would be assigned a negative value,
which is clearly not a rate, and success would be returned.

Reinstate previous logic, which would just return error.

Fixes: afd529d74002 ("ASoC: stm: stm32_i2s: convert from round_rate() to determine_rate()")
Link: https://scan7.scan.coverity.com/#/project-view/53936/11354?selectedIssue=1647702
Signed-off-by: Sergio Perez Gonzalez <sperezglz@gmail.com>
Link: https://patch.msgid.link/20250729020052.404617-1-sperezglz@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/stm/stm32_i2s.c