cachefiles: Clean up in cachefiles_commit_tmpfile()
authorZizhi Wo <wozizhi@huawei.com>
Thu, 7 Nov 2024 11:06:47 +0000 (19:06 +0800)
committerChristian Brauner <brauner@kernel.org>
Mon, 11 Nov 2024 13:39:38 +0000 (14:39 +0100)
commit09ecf8f5505465b5527a39dff4b159af62306eee
tree1488750fa31527c2bd65d5f36dd8fdeb6c73782e
parent56f4856b425a30e1d8b3e41e6cde8bfba90ba5f8
cachefiles: Clean up in cachefiles_commit_tmpfile()

Currently, cachefiles_commit_tmpfile() will only be called if object->flags
is set to CACHEFILES_OBJECT_USING_TMPFILE. Only cachefiles_create_file()
and cachefiles_invalidate_cookie() set this flag. Both of these functions
replace object->file with the new tmpfile, and both are called by
fscache_cookie_state_machine(), so there are no concurrency issues.

So the equation "d_backing_inode(dentry) == file_inode(object->file)" in
cachefiles_commit_tmpfile() will never hold true according to the above
conditions. This patch removes this part of the redundant code and does not
involve any other logical changes.

Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
Link: https://lore.kernel.org/r/20241107110649.3980193-4-wozizhi@huawei.com
Acked-by: David Howells <dhowells@redhat.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/cachefiles/namei.c