mlxsw: pci: Lock configuration space of upstream bridge during reset
authorIdo Schimmel <idosch@nvidia.com>
Mon, 8 Jul 2024 14:23:42 +0000 (16:23 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 10 Jul 2024 01:46:44 +0000 (18:46 -0700)
commit0970836c348b6bc2ea77ce4348a136d6febfd440
tree67976b73d33ce9e1853fac36a95ea81df4b9cfe0
parenta22f3bc80075c10c3835b9ec1c7da17496386904
mlxsw: pci: Lock configuration space of upstream bridge during reset

The driver triggers a "Secondary Bus Reset" (SBR) by calling
__pci_reset_function_locked() which asserts the SBR bit in the "Bridge
Control Register" in the configuration space of the upstream bridge for
2ms. This is done without locking the configuration space of the
upstream bridge port, allowing user space to access it concurrently.

Linux 6.11 will start warning about such unlocked resets [1][2]:

pcieport 0000:00:01.0: unlocked secondary bus reset via: pci_reset_bus_function+0x51c/0x6a0

Avoid the warning and the concurrent access by locking the configuration
space of the upstream bridge prior to the reset and unlocking it
afterwards.

[1] https://lore.kernel.org/all/171711746953.1628941.4692125082286867825.stgit@dwillia2-xfh.jf.intel.com/
[2] https://lore.kernel.org/all/20240531213150.GA610983@bhelgaas/

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link: https://patch.msgid.link/9937b0afdb50f2f2825945393c94c093c04a5897.1720447210.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/pci.c