can: j1939: j1939_local_ecu_get(): undo increment when j1939_local_ecu_get() fails
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sun, 24 Aug 2025 10:27:40 +0000 (19:27 +0900)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 10 Sep 2025 15:12:05 +0000 (17:12 +0200)
commit06e02da29f6f1a45fc07bd60c7eaf172dc21e334
tree9938725f835c20310082420d9f622cf49dbe0b4d
parentf214744c8a27c3c1da6b538c232da22cd027530e
can: j1939: j1939_local_ecu_get(): undo increment when j1939_local_ecu_get() fails

Since j1939_sk_bind() and j1939_sk_release() call j1939_local_ecu_put()
when J1939_SOCK_BOUND was already set, but the error handling path for
j1939_sk_bind() will not set J1939_SOCK_BOUND when j1939_local_ecu_get()
fails, j1939_local_ecu_get() needs to undo priv->ents[sa].nusers++ when
j1939_local_ecu_get() returns an error.

Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol")
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Tested-by: Oleksij Rempel <o.rempel@pengutronix.de>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://patch.msgid.link/e7f80046-4ff7-4ce2-8ad8-7c3c678a42c9@I-love.SAKURA.ne.jp
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
net/can/j1939/bus.c