xen-blkback: Advertise feature-persistent as user requested
authorSeongJae Park <sj@kernel.org>
Wed, 31 Aug 2022 16:58:22 +0000 (16:58 +0000)
committerJuergen Gross <jgross@suse.com>
Fri, 2 Sep 2022 09:05:06 +0000 (11:05 +0200)
commit06ba5d2e943e97bb66e75c152e87f1d2c7027a67
tree6f6efc8e597f36e9e21fb6e1eb76a72d746441c9
parentc5deb27895e017a0267de0a20d140ad5fcc55a54
xen-blkback: Advertise feature-persistent as user requested

The advertisement of the persistent grants feature (writing
'feature-persistent' to xenbus) should mean not the decision for using
the feature but only the availability of the feature.  However, commit
aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent
grants") made a field of blkback, which was a place for saving only the
negotiation result, to be used for yet another purpose: caching of the
'feature_persistent' parameter value.  As a result, the advertisement,
which should follow only the parameter value, becomes inconsistent.

This commit fixes the misuse of the semantic by making blkback saves the
parameter value in a separate place and advertises the support based on
only the saved value.

Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants")
Cc: <stable@vger.kernel.org> # 5.10.x
Suggested-by: Juergen Gross <jgross@suse.com>
Signed-off-by: SeongJae Park <sj@kernel.org>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Link: https://lore.kernel.org/r/20220831165824.94815-2-sj@kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/block/xen-blkback/common.h
drivers/block/xen-blkback/xenbus.c