drm/xe: Fix unbind of unaccessed VMA (fault mode)
authorBrian Welty <brian.welty@intel.com>
Thu, 2 Nov 2023 23:04:53 +0000 (16:04 -0700)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:43:34 +0000 (11:43 -0500)
commit04dfef5b41afc85e8de7b0397050cdb51db35eda
tree74bea2fe86d66ed26d8094b670f263e9119ab1ba
parent6ffef7b6991b4e302dd0aa86f67a0d00b0b8e542
drm/xe: Fix unbind of unaccessed VMA (fault mode)

In fault mode, page table binding is deferred until fault handler.
Thus vma->tile_present will be unset unless the VMA is accessed by GPU.

During a later unbind, the logic doesn't account for the fact that local
fence variable will be NULL in this case, leading to pass NULL into
dma_fence_add_callback() and causing few WARN_ONs to print to console.
The fix is already present in the code, just hoist the fence variable
computation to be done earlier.

Resolves warnings seen with igt@xe_exec_fault_mode@once-invalid-fault

Signed-off-by: Brian Welty <brian.welty@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_vm.c