perf bpf: Fix two memory leakages when calling perf_env__insert_bpf_prog_info()
authorZhongqiu Han <quic_zhonhan@quicinc.com>
Thu, 5 Dec 2024 08:45:00 +0000 (16:45 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 10 Dec 2024 19:59:32 +0000 (16:59 -0300)
commit03edb7020bb920f1935c3f30acad0bb27fdb99af
treeb04c1708c6eee8cc98a10a69669f3efccb5dab5c
parenta7da6c7030e1aec32f0a41c7b4fa70ec96042019
perf bpf: Fix two memory leakages when calling perf_env__insert_bpf_prog_info()

If perf_env__insert_bpf_prog_info() returns false due to a duplicate bpf
prog info node insertion, the temporary info_node and info_linear memory
will leak. Add a check to ensure the memory is freed if the function
returns false.

Fixes: d56354dc49091e33 ("perf tools: Save bpf_prog_info and BTF of new BPF programs")
Reviewed-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@linaro.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Song Liu <song@kernel.org>
Cc: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/20241205084500.823660-4-quic_zhonhan@quicinc.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/bpf-event.c
tools/perf/util/env.c
tools/perf/util/env.h