rapidio: fix possible UAF when kfifo_alloc() fails
authorWang Weiyang <wangweiyang2@huawei.com>
Wed, 23 Nov 2022 09:51:47 +0000 (17:51 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 12 Dec 2022 03:30:18 +0000 (19:30 -0800)
commit02d7d89f816951e0862147d751b1150d67aaebdd
treedd72db756eb91ca90bd08308936c1ef1c8d9626e
parent3f0dad0105133ffcfa13eb0cd980fa347bcf31d7
rapidio: fix possible UAF when kfifo_alloc() fails

If kfifo_alloc() fails in mport_cdev_open(), goto err_fifo and just free
priv. But priv is still in the chdev->file_list, then list traversal
may cause UAF. This fixes the following smatch warning:

drivers/rapidio/devices/rio_mport_cdev.c:1930 mport_cdev_open() warn: '&priv->list' not removed from list

Link: https://lkml.kernel.org/r/20221123095147.52408-1-wangweiyang2@huawei.com
Fixes: e8de370188d0 ("rapidio: add mport char device driver")
Signed-off-by: Wang Weiyang <wangweiyang2@huawei.com>
Cc: Alexandre Bounine <alex.bou9@gmail.com>
Cc: Dan Carpenter <error27@gmail.com>
Cc: Jakob Koschel <jakobkoschel@gmail.com>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Matt Porter <mporter@kernel.crashing.org>
Cc: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/rapidio/devices/rio_mport_cdev.c