kernel/module: Use BUG_ON instead of if condition followed by BUG
authorzhouchuangao <zhouchuangao@vivo.com>
Wed, 12 May 2021 14:01:57 +0000 (07:01 -0700)
committerJessica Yu <jeyu@kernel.org>
Fri, 14 May 2021 07:50:56 +0000 (09:50 +0200)
commit02b2fb455b2e80a0a831d067ab7ef950e2991eee
treeffdbab3ce2111566035c44fc5e8b07a8daaa4129
parent6efb943b8616ec53a5e444193dccf1af9ad627b5
kernel/module: Use BUG_ON instead of if condition followed by BUG

Fix the following coccinelle report:

kernel/module.c:1018:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

BUG_ON uses unlikely in if(). Through disassembly, we can see that
brk #0x800 is compiled to the end of the function.
As you can see below:
    ......
    ffffff8008660bec:   d65f03c0    ret
    ffffff8008660bf0:   d4210000    brk #0x800

Usually, the condition in if () is not satisfied. For the
multi-stage pipeline, we do not need to perform fetch decode
and excute operation on brk instruction.

In my opinion, this can improve the efficiency of the
multi-stage pipeline.

Signed-off-by: zhouchuangao <zhouchuangao@vivo.com>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
kernel/module.c