ALSA: xen-front: fix unsigned error check on return from to_sndif_format
authorColin Ian King <colin.king@canonical.com>
Sun, 27 May 2018 21:32:19 +0000 (22:32 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 28 May 2018 09:30:33 +0000 (11:30 +0200)
commit014cea591afac9b3dae61793446f83d5be634203
tree74f51d3aa884454b4c6d8dc3003ebd813d61c1c4
parent3d6246173798fc7a81a69ad3fd0dd55fa1779068
ALSA: xen-front: fix unsigned error check on return from to_sndif_format

The negative error return from the call to to_sndif_format is being
assigned to an unsigned 8 bit integer and hence the check for a negative
value is always going to be false.  Fix this by using ret as the error
return and hence the negative error can be detected and assign
the u8 sndif_format to ret if there is no error.

Detected by CoverityScan, CID#1469385 ("Unsigned compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamoccchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/xen/xen_snd_front_alsa.c