mptcp: fix rcv space initialization
authorPaolo Abeni <pabeni@redhat.com>
Thu, 8 Feb 2024 18:03:50 +0000 (19:03 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 12 Feb 2024 10:08:12 +0000 (10:08 +0000)
commit013e3179dbd2bc756ce1dd90354abac62f65b739
tree44c1cc3b5496e7009ff16f790979ac96d1c4c027
parentbdd70eb68913c960acb895b00a8c62eb64715b1f
mptcp: fix rcv space initialization

mptcp_rcv_space_init() is supposed to happen under the msk socket
lock, but active msk socket does that without such protection.

Leverage the existing mptcp_propagate_state() helper to that extent.
We need to ensure mptcp_rcv_space_init will happen before
mptcp_rcv_space_adjust(), and the release_cb does not assure that:
explicitly check for such condition.

While at it, move the wnd_end initialization out of mptcp_rcv_space_init(),
it never belonged there.

Note that the race does not produce ill effect in practice, but
change allows cleaning-up and defying better the locking model.

Fixes: a6b118febbab ("mptcp: add receive buffer auto-tuning")
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/mptcp/protocol.c
net/mptcp/protocol.h
net/mptcp/subflow.c