drm/vc4: Call drm_atomic_helper_shutdown() at shutdown time
authorDouglas Anderson <dianders@chromium.org>
Fri, 1 Sep 2023 23:39:54 +0000 (16:39 -0700)
committerDouglas Anderson <dianders@chromium.org>
Thu, 21 Sep 2023 17:49:04 +0000 (10:49 -0700)
commit013d382d11a29ee13023c21dade684f98e47ec5a
tree588d015a34cbb270162c7b714990dbf2d9ec7b0a
parentce3d99c8349584bc0fbe1e21918a3ea1155343aa
drm/vc4: Call drm_atomic_helper_shutdown() at shutdown time

Based on grepping through the source code these drivers appear to be
missing a call to drm_atomic_helper_shutdown() at system shutdown
time. Among other things, this means that if a panel is in use that it
won't be cleanly powered off at system shutdown time.

The fact that we should call drm_atomic_helper_shutdown() in the case
of OS shutdown/restart comes straight out of the kernel doc "driver
instance overview" in drm_drv.c.

Suggested-by: Maxime Ripard <mripard@kernel.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230901163944.RFT.3.I10dbe099fb1059d304ba847d19fc45054f7ffe9f@changeid
drivers/gpu/drm/vc4/vc4_drv.c