media: rkvdec: Add required padding
authorAndrzej Pietrasiewicz <andrzej.p@collabora.com>
Thu, 27 Oct 2022 08:02:17 +0000 (10:02 +0200)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 4 Nov 2022 15:56:42 +0000 (16:56 +0100)
commit00c47aa85bb26450edc6059c3d245de062e60b5d
tree2a989c6aff8802285bd370879d729ac74735b199
parent5b16db4fbba452aacfbb0bfd9a2c81cd0cd52b30
media: rkvdec: Add required padding

The addresses of two elements of the segmap[][] member are passed to the
hardware which expects 128-bit aligned addresses. However, without this
patch offsetof(struct rkvdec_vp9_priv_tbl, segmap[0]) is an odd number
(2421) but the hardware just ignores the 5 least significant bits of the
address. As a result, the hardware writes the segmentation map to incorrect
locations.

Inserting 11 bytes of padding corrects this situation by making the said
addresses divisible by 16 (i.e. aligned on a 128-bit boundary).

Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Fixes: f25709c4ff15 ("media: rkvdec: Add the VP9 backend")
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/staging/media/rkvdec/rkvdec-vp9.c