regmap: maple: Fix cache corruption in regcache_maple_drop()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Wed, 27 Mar 2024 11:44:06 +0000 (11:44 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 27 Mar 2024 15:00:28 +0000 (15:00 +0000)
commit00bb549d7d63a21532e76e4a334d7807a54d9f31
tree22b708471b781b7be89f75aef8f8633eaebd4b65
parent4cece764965020c22cff7665b18a012006359095
regmap: maple: Fix cache corruption in regcache_maple_drop()

When keeping the upper end of a cache block entry, the entry[] array
must be indexed by the offset from the base register of the block,
i.e. max - mas.index.

The code was indexing entry[] by only the register address, leading
to an out-of-bounds access that copied some part of the kernel
memory over the cache contents.

This bug was not detected by the regmap KUnit test because it only
tests with a block of registers starting at 0, so mas.index == 0.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: f033c26de5a5 ("regmap: Add maple tree based register cache")
Link: https://msgid.link/r/20240327114406.976986-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regcache-maple.c