Revert "net: stmmac: re-init rx buffers when mac resume back"
authorThierry Reding <treding@nvidia.com>
Wed, 14 Apr 2021 15:10:07 +0000 (17:10 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Apr 2021 21:06:17 +0000 (14:06 -0700)
commit00423969d806d7169d16fa6314c570a472ca26c9
tree43400feb26786cb59af67b1607c50ac3fe3518f0
parent416dcc5ce9d2a810477171c62ffa061a98f87367
Revert "net: stmmac: re-init rx buffers when mac resume back"

This reverts commit 9c63faaa931e443e7abbbee9de0169f1d4710546, which
introduces a suspend/resume regression on Jetson TX2 boards that can be
reproduced every time. Given that the issue that this was supposed to
fix only occurs very sporadically the safest course of action is to
revert before v5.12 and then we can have another go at fixing the more
rare issue in the next release (and perhaps backport it if necessary).

The root cause of the observed problem seems to be that when the system
is suspended, some packets are still in transit. When the descriptors
for these buffers are cleared on resume, the descriptors become invalid
and cause a fatal bus error.

Link: https://lore.kernel.org/r/708edb92-a5df-ecc4-3126-5ab36707e275@nvidia.com/
Reported-by: Jonathan Hunter <jonathanh@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c