kconfig: Fix automatic menu creation mem leak
authorUlf Magnusson <ulfalizer@gmail.com>
Sun, 8 Oct 2017 17:35:44 +0000 (19:35 +0200)
committerMasahiro Yamada <yamada.masahiro@socionext.com>
Sun, 21 Jan 2018 15:49:26 +0000 (00:49 +0900)
commitae7440ef0c8013d68c00dad6900e7cce5311bb1c
treedb7b1c09f2a860a317e06a8158fd0a7586676fa9
parent0724a7c32a54e3e50d28e19e30c59014f61d4e2c
kconfig: Fix automatic menu creation mem leak

expr_trans_compare() always allocates and returns a new expression,
giving the following leak outline:

...
*Allocate*
basedep = expr_trans_compare(basedep, E_UNEQUAL, &symbol_no);
...
for (menu = parent->next; menu; menu = menu->next) {
...
*Copy*
dep2 = expr_copy(basedep);
...
*Free copy*
expr_free(dep2);
}
*basedep lost!*

Fix by freeing 'basedep' after the loop.

Summary from Valgrind on 'menuconfig' (ARCH=x86) before the fix:

LEAK SUMMARY:
   definitely lost: 344,376 bytes in 14,349 blocks
   ...

Summary after the fix:

LEAK SUMMARY:
   definitely lost: 44,448 bytes in 1,852 blocks
   ...

Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
scripts/kconfig/menu.c