randstruct: Whitelist UNIXCB cast
authorKees Cook <keescook@chromium.org>
Wed, 5 Apr 2017 04:35:22 +0000 (21:35 -0700)
committerKees Cook <keescook@chromium.org>
Thu, 22 Jun 2017 23:21:41 +0000 (16:21 -0700)
commitb07b65846ba33a4deba03eb6e39043c8bc70903b
tree9d9179213690fc7e67aee1e2c602c30a574719f7
parentfd466e068e5adef5922b76f24374c96ba01faaa2
randstruct: Whitelist UNIXCB cast

This is another false positive in bad cast detection:

net/unix/af_unix.c: In function ‘unix_skb_scm_eq’:
net/unix/af_unix.c:1621:31: note: found mismatched rhs struct pointer types: ‘struct unix_skb_parms’ and ‘char’

  const struct unix_skb_parms *u = &UNIXCB(skb);
                               ^

UNIXCB is:

#define UNIXCB(skb)     (*(struct unix_skb_parms *)&((skb)->cb))

And ->cb is:

char                    cb[48] __aligned(8);

This is a rather crazy cast, but appears to be safe in the face of
randomization, so whitelist it in the plugin.

Cc: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Kees Cook <keescook@chromium.org>
scripts/gcc-plugins/randomize_layout_plugin.c