sock: fix sendmmsg for partial sendmsg
authorSoheil Hassas Yeganeh <soheil@google.com>
Fri, 4 Nov 2016 19:36:49 +0000 (15:36 -0400)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Nov 2016 18:18:12 +0000 (13:18 -0500)
commit3023898b7d4aac65987bd2f485cc22390aae6f78
tree3fe67de03ca86d42dfeeda2be5d77821f25f186f
parentaa5fd0fb77486b8a6764ead8627baa14790e4280
sock: fix sendmmsg for partial sendmsg

Do not send the next message in sendmmsg for partial sendmsg
invocations.

sendmmsg assumes that it can continue sending the next message
when the return value of the individual sendmsg invocations
is positive. It results in corrupting the data for TCP,
SCTP, and UNIX streams.

For example, sendmmsg([["abcd"], ["efgh"]]) can result in a stream
of "aefgh" if the first sendmsg invocation sends only the first
byte while the second sendmsg goes through.

Datagram sockets either send the entire datagram or fail, so
this patch affects only sockets of type SOCK_STREAM and
SOCK_SEQPACKET.

Fixes: 228e548e6020 ("net: Add sendmmsg socket system call")
Signed-off-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: Neal Cardwell <ncardwell@google.com>
Acked-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/socket.c