net_sched: properly check for empty skb array on error path
authorCong Wang <xiyou.wangcong@gmail.com>
Mon, 18 Dec 2017 22:34:26 +0000 (14:34 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 19 Dec 2017 19:13:12 +0000 (14:13 -0500)
commit1df94c3c5dadbce3df6cc0e989d8c85d43a903d6
tree443baff71ebce34735a8c765852330e6e77f3821
parent4eb50ceb5c156a166c0b00ac27f0ff3a0943cdfb
net_sched: properly check for empty skb array on error path

First, the check of &q->ring.queue against NULL is wrong, it
is always false. We should check the value rather than the address.

Secondly, we need the same check in pfifo_fast_reset() too,
as both ->reset() and ->destroy() are called in qdisc_destroy().

Fixes: c5ad119fb6c0 ("net: sched: pfifo_fast use skb_array")
Reported-by: syzbot <syzkaller@googlegroups.com>
Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_generic.c