mptcp: return 0 instead of 'err' var
authorMatthieu Baerts <matthieu.baerts@tessares.net>
Fri, 9 Dec 2022 00:44:31 +0000 (16:44 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 10 Dec 2022 03:46:11 +0000 (19:46 -0800)
commit03e7d28cd25ee6ff731386fb154d03f76dede1cc
tree1a4ecba88e58f0dc8bf1d78eb7c592a686c1170b
parent8b34b52c1794932a16308631121b758830349ae9
mptcp: return 0 instead of 'err' var

When 'err' is 0, it looks clearer to return '0' instead of the variable
called 'err'.

The behaviour is then not modified, just a clearer code.

By doing this, we can also avoid false positive smatch warnings like
this one:

  net/mptcp/pm_netlink.c:1169 mptcp_pm_parse_pm_addr_attr() warn: missing error code? 'err'

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Suggested-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/pm_netlink.c
net/mptcp/sockopt.c