net: Avoid receiving packets with an l3mdev on unbound UDP sockets
authorRobert Shearman <rshearma@brocade.com>
Thu, 26 Jan 2017 18:02:24 +0000 (18:02 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Jan 2017 20:00:58 +0000 (15:00 -0500)
commit63a6fff353d01da5a22b72670c434bf12fa0e3b8
tree5707ae376777271ab2d77411fed89afb515f0257
parenta3a4de056ed5cfb22085173d8f0f13b0ca6b6d60
net: Avoid receiving packets with an l3mdev on unbound UDP sockets

Packets arriving in a VRF currently are delivered to UDP sockets that
aren't bound to any interface. TCP defaults to not delivering packets
arriving in a VRF to unbound sockets. IP route lookup and socket
transmit both assume that unbound means using the default table and
UDP applications that haven't been changed to be aware of VRFs may not
function correctly in this case since they may not be able to handle
overlapping IP address ranges, or be able to send packets back to the
original sender if required.

So add a sysctl, udp_l3mdev_accept, to control this behaviour with it
being analgous to the existing tcp_l3mdev_accept, namely to allow a
process to have a VRF-global listen socket. Have this default to off
as this is the behaviour that users will expect, given that there is
no explicit mechanism to set unmodified VRF-unaware application into a
default VRF.

Signed-off-by: Robert Shearman <rshearma@brocade.com>
Acked-by: David Ahern <dsa@cumulusnetworks.com>
Tested-by: David Ahern <dsa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Documentation/networking/ip-sysctl.txt
Documentation/networking/vrf.txt
include/net/netns/ipv4.h
net/ipv4/sysctl_net_ipv4.c
net/ipv4/udp.c
net/ipv6/udp.c