ipv4: Drop leaf from suffix pull/push functions
authorAlexander Duyck <alexander.h.duyck@intel.com>
Thu, 1 Dec 2016 12:27:52 +0000 (07:27 -0500)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2016 18:15:58 +0000 (13:15 -0500)
commit1a239173cccff726b60ac6a9c79ae4a1e26cfa49
tree1d60c464560140c9805472cf17e258a7b0ff28b7
parentc66ebf2db555c6ed705044eabd2b37dcd546f68b
ipv4: Drop leaf from suffix pull/push functions

It wasn't necessary to pass a leaf in when doing the suffix updates so just
drop it.  Instead just pass the suffix and work with that.

Since we dropped the leaf there is no need to include that in the name so
the names are updated to node_push_suffix and node_pull_suffix.

Finally I noticed that the logic for pulling the suffix length back
actually had some issues.  Specifically it would stop prematurely if there
was a longer suffix, but it was not as long as the original suffix.  I
updated the code to address that in node_pull_suffix.

Fixes: 5405afd1a306 ("fib_trie: Add tracking value for suffix length")
Suggested-by: Robert Shearman <rshearma@brocade.com>
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Reviewed-by: Robert Shearman <rshearma@brocade.com>
Tested-by: Robert Shearman <rshearma@brocade.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/fib_trie.c